[FrameworkBundle][Workflow] Add WorflowGuardListenerPass only if it exists
#52188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
WorflowGuardListenerPass only if it exists
fabpot
approved these changes
Oct 20, 2023
|
Thank you @smnandre. |
|
We'd need this also for use DataCollectorTranslatorPass and LoggingTranslatorPass, isn't it? |
|
Yes, see #52190 😄 |
|
Thank you @smnandre, just to feedback that this did fix the issue after composer update, in the 6.4.x project that identified it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @PhilETaylor (in this comment) the framework is broken in 6.4-dev when the worflow component is not installed.
This PR fixes that by registering the compiler pass only if available.