Skip to content

[FrameworkBundle] Fix requiring moved translation compiler passes #52190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

[FrameworkBundle] Fix requiring moved translation compiler passes #52190

merged 1 commit into from
Oct 20, 2023

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #52032 (comment)
License MIT

Those 2 also need to be required conditionally since symfony/translation is not a hard dependency of FWB.

@carsonbot carsonbot added this to the 6.4 milestone Oct 20, 2023
@smnandre
Copy link
Member

Arf I should have checked them too, sorry

@fancyweb fancyweb mentioned this pull request Oct 20, 2023
Merged
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 4292cc0 into symfony:6.4 Oct 20, 2023
@fancyweb fancyweb deleted the fwb/fix-cp-stuff branch October 20, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @smnandre @nicolas-grekas @carsonbot