[TypeInfo] Remove deprecated code for non-array based collections #60988
+33
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mttsch
commented
Jun 30, 2025
mttsch
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
I could not find a reference to the removed code in Symfony docs, thus I do not think they need updates. Also see the docs issue for the deprecations: symfony/symfony-docs#20602 |
mtarld
changed the title
mtarld
requested changes
Jul 1, 2025
mttsch
force-pushed
the
feature/type_info_array_collection
branch
from
042d3f7 to
d522388
Compare
mtarld
requested changes
Jul 1, 2025
Comment on lines
+10
to
+15
| ```diff | ||
| use Symfony\Component\TypeInfo\Type; | ||
|
|
||
| -$type = Type::iterable(Type::string(), asList: true); | ||
| +$type = Type::list(Type::string()); | ||
| ``` |
There was a problem hiding this comment.
We usually don't put diffs in changelogs 🙂
There was a problem hiding this comment.
I am sorry, but I am getting really mixed signals. In another PR, the UPGRADE contains before/after examples, the CHANGELOG did not. There it is suggested (by a Symfony Core Member) to also add before/after examples to the CHANGELOG. In this PR, it is suggested, to not do it.
I am happy to do the changes, but it appears that - unless I am misunderstanding things - there seems to be no consensus on this topic 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.