-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[TypeInfo] Remove deprecated code for non-array based collections #60988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.0
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,19 @@ | ||
CHANGELOG | ||
========= | ||
|
||
8.0 | ||
--- | ||
|
||
* Constructing a `CollectionType` instance as a list that is not an array throws an `InvalidArgumentException` | ||
* Remove the third `$asList` argument of `TypeFactoryTrait::iterable()`, use `TypeFactoryTrait::list()` instead | ||
|
||
```diff | ||
use Symfony\Component\TypeInfo\Type; | ||
|
||
-$type = Type::iterable(Type::string(), asList: true); | ||
+$type = Type::list(Type::string()); | ||
``` | ||
Comment on lines
+10
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We usually don't put diffs in changelogs 🙂 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am sorry, but I am getting really mixed signals. In another PR, the UPGRADE contains before/after examples, the CHANGELOG did not. There it is suggested (by a Symfony Core Member) to also add before/after examples to the CHANGELOG. In this PR, it is suggested, to not do it. I am happy to do the changes, but it appears that - unless I am misunderstanding things - there seems to be no consensus on this topic 🙂 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this example is necessary tbh, the sentance is self-sufficient to me. Anyway I'd say diffs are cool for CHANGELOGs as well as UPGRADE files :) |
||
|
||
7.3 | ||
--- | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.