[Messenger] use ServicesResetterInterface instead of concrete ServicesResetter in ResetServicesListener
#60999
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
force-pushed
the
refactor/use-interface-in-reset-services-listener
branch
from
c0f0ae3 to
aa6fb3b
Compare
|
Hi 👋 I hope you're all doing well! I think this kind of change is acceptable in a new major version (like now), but if I'm mistaken, I'm happy to update the PR. |
santysisi
force-pushed
the
refactor/use-interface-in-reset-services-listener
branch
from
aa6fb3b to
814a6d8
Compare
|
The change itself looks reasonable to me, but that's a new feature and we should merge it into the |
stof
reviewed
Jul 1, 2025
| @@ -31,7 +32,8 @@ public static function provideResetServices(): iterable | |||
| */ | |||
| public function testResetServices(bool $shouldReset) | |||
| { | |||
| $servicesResetter = $this->createMock(ServicesResetter::class); | |||
| /** @var ServicesResetterInterface&MockObject $servicesResetter */ | |||
There was a problem hiding this comment.
this @var is not necessary. $this->createMock already has this as return type.
santysisi
force-pushed
the
refactor/use-interface-in-reset-services-listener
branch
from
814a6d8 to
a240e9a
Compare
…icesResetter` in `ResetServicesListener`
santysisi
force-pushed
the
refactor/use-interface-in-reset-services-listener
branch
from
a240e9a to
83714d6
Compare
|
Hi 👋 I hope you're all doing well! |
stof
approved these changes
Jul 1, 2025
alexandre-daubois
approved these changes
Jul 1, 2025
xabbuh
reviewed
Jul 1, 2025
| 8.0 | ||
| --- | ||
|
|
||
| * Use `ServicesResetterInterface` instead of concrete `ServicesResetter` in `ResetServicesListener` |
There was a problem hiding this comment.
Suggested change
| * Use `ServicesResetterInterface` instead of concrete `ServicesResetter` in `ResetServicesListener` | |
| * Allow any `ServiceResetterInterface` implementation in `ResetServicesListener` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
ResetServicesListenerto depend on theServicesResetterInterfaceinstead of the concreteServicesResetterclass.