Skip to content

[Messenger][Translation] do not mock final classes #61003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 1, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #60991
License MIT

@carsonbot

This comment was marked as outdated.

@GromNaN
Copy link
Member

GromNaN commented Jul 1, 2025

The class is soft-@final in 7.4, can we backport the fix to 7.4 to facilitate LTS?

@xabbuh xabbuh changed the base branch from 8.0 to 7.4 July 1, 2025 07:43
@xabbuh xabbuh modified the milestones: 8.0, 7.4 Jul 1, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Jul 1, 2025

rebased on 7.4

@xabbuh xabbuh merged commit 445eb96 into symfony:7.4 Jul 1, 2025
11 checks passed
@xabbuh xabbuh deleted the issue-60991 branch July 1, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger][Translation] Final classes cause test failures
4 participants