[Console] Escape exception message during the rendering of an exception #8853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the reccord, here is the output before my patch: (see |
|
IIRC, we do have error messages that have some ANSI sequences. |
|
The only one which can be "interesting" is if (OutputInterface::VERBOSITY_VERBOSE <= $output->getVerbosity()) {
$output->writeln('<comment>Exception trace:</comment>');
// exception related properties
$trace = $e->getTrace();But it is not ;) |
|
So, what's the status of this PR? |
|
IMHO, it's merge-able. |
|
ok, can you do the same PR on 2.2 and add a test when using a valid tag to prove that it does not mess up those? |
|
What is a valid tag ? something like |
|
Everything that is registered as a style on |
This PR was merged into the 2.2 branch. Discussion ---------- [DomCrawler] Added missing docblocks and removed redundant type in a return annotation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- d414213 [DomCrawler] Added missing docblocks and removed unneeded return annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the exception message contains some HTML, this display is
broken.
I don't know enought about the differents Output classes.
Maybe we have to check the current Output class before
escaping. But for the moment, we allways format the message
with error tags, so I guess the escape is not an issue.
As this is a bug fix, should I re-open this PR against 2.2 branch ?