feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown #10392

bkks1004 · 2024-11-25T13:29:10Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: [prefer-promise-reject-errors] Options to allow any and unknown #10375
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2024-11-25T13:29:14Z

Thanks for the PR, @bkks1004!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-11-25T13:29:25Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`6e98571`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/674dd250626b3e000873d893
😎 Deploy Preview	https://deploy-preview-10392--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-11-25T13:30:12Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6e98571. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run repo-tools:postinstall-script

Sent with 💌 from NxCloud.

codecov · 2024-11-25T13:45:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (c1b1106) to head (d600328).
Report is 8 commits behind head on main.

❗ Current head d600328 differs from pull request most recent head 6e98571

Please upload reports for the commit 6e98571 to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10392   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         443      443           
  Lines       15289    15293    +4     
  Branches     4446     4448    +2     
=======================================
+ Hits        13264    13268    +4     
  Misses       1672     1672           
  Partials      353      353

Flag	Coverage Δ
unittest	`86.75% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...t-plugin/src/rules/prefer-promise-reject-errors.ts	`100.00% <100.00%> (ø)`

JoshuaKGoldberg

Looks great to me, thanks! 🚀

packages/eslint-plugin/docs/rules/prefer-promise-reject-errors.mdx

JoshuaKGoldberg · 2024-12-02T15:29:13Z

packages/eslint-plugin/tests/rules/prefer-promise-reject-errors.test.ts

[Praise] These test cases are super clean, nice. 🔥

@bkks1004

##### [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02) ##### 🚀 Features - **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392)) ##### 🩹 Fixes - **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304)) - **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401)) - **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363)) ##### ❤️ Thank You - Kim OhSeong [@bkks1004](https://github.com/bkks1004) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs) - Ronen Amiel You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@bkks1004

##### [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02) ##### 🚀 Features - **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392)) ##### 🩹 Fixes - **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304)) - **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401)) - **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363)) ##### ❤️ Thank You - Kim OhSeong [@bkks1004](https://github.com/bkks1004) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs) - Ronen Amiel You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@bkks1004

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.16.0 | 8.17.0 | | npm | @typescript-eslint/parser | 8.16.0 | 8.17.0 | ## [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02) ##### 🚀 Features - **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392)) ##### 🩹 Fixes - **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304)) - **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401)) - **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363)) ##### ❤️ Thank You - Kim OhSeong [@bkks1004](https://github.com/bkks1004) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs) - Ronen Amiel You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@bkks1004

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.16.0 | 8.17.0 | | npm | @typescript-eslint/parser | 8.16.0 | 8.17.0 | ## [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02) ##### 🚀 Features - **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392)) ##### 🩹 Fixes - **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304)) - **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401)) - **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363)) ##### ❤️ Thank You - Kim OhSeong [@bkks1004](https://github.com/bkks1004) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs) - Ronen Amiel You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

feat: [prefer-promise-reject-errors] Options to allow any and unknown

4f2f7de

bkks1004 changed the title ~~feat: [prefer-promise-reject-errors] Options to allow any and unknown~~ feat(eslint-plugin): [prefer-promise-reject-errors] Options to allow any and unknown Nov 25, 2024

injae-kim mentioned this pull request Nov 25, 2024

Enhancement: [prefer-promise-reject-errors] Options to allow any and unknown #10375

Closed

4 tasks

bkks1004 changed the title ~~feat(eslint-plugin): [prefer-promise-reject-errors] Options to allow any and unknown~~ feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown Nov 25, 2024

Merge branch 'main' into main

d600328

JoshuaKGoldberg previously approved these changes Dec 2, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/prefer-promise-reject-errors.mdx Outdated Show resolved Hide resolved

packages/eslint-plugin/docs/rules/prefer-promise-reject-errors.mdx Outdated Show resolved Hide resolved

JoshuaKGoldberg reviewed Dec 2, 2024

View reviewed changes

JoshuaKGoldberg dismissed their stale review via 6e98571 December 2, 2024 15:29

Apply suggestions from code review

6e98571

JoshuaKGoldberg merged commit 670df27 into typescript-eslint:main Dec 2, 2024
7 of 8 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown #10392

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown #10392

Uh oh!

bkks1004 commented Nov 25, 2024 •

edited

Loading

Uh oh!

typescript-eslint bot commented Nov 25, 2024

Uh oh!

netlify bot commented Nov 25, 2024 •

edited

Loading

Uh oh!

nx-cloud bot commented Nov 25, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 25, 2024 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg Dec 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown #10392

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown #10392

Uh oh!

Conversation

bkks1004 commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Nov 25, 2024

Uh oh!

netlify bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecov bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bkks1004 commented Nov 25, 2024 •

edited

Loading

netlify bot commented Nov 25, 2024 •

edited

Loading

nx-cloud bot commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading