Skip to content

fix(eslint-plugin): remove references to "extendDefaults" in no-restricted-types #10401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

MariaSolOs
Copy link
Contributor

@MariaSolOs MariaSolOs commented Nov 27, 2024

PR Checklist

Overview

It seems like the extendDefaults setting from ban-types was ported into no-restricted-types, but that setting isn't part of the new rule's documentation nor it's used in its implementation.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MariaSolOs!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 589e2d1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/674766a70ecda30008ac539f
😎 Deploy Preview https://deploy-preview-10401--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Nov 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 589e2d1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@MariaSolOs MariaSolOs changed the title fix(docs): remove references to "extendDefaults" in no-restricted-types fix(eslint-plugin): remove references to "extendDefaults" in no-restricted-types Nov 27, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! 🧹

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin): remove references to "extendDefaults" in no-restricted-types docs(eslint-plugin): remove references to "extendDefaults" in no-restricted-types Nov 27, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title docs(eslint-plugin): remove references to "extendDefaults" in no-restricted-types fix(eslint-plugin): remove references to "extendDefaults" in no-restricted-types Nov 27, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 27, 2024
@kirkwaiblinger kirkwaiblinger merged commit 9dbb4f9 into typescript-eslint:main Nov 27, 2024
75 of 77 checks passed
@MariaSolOs MariaSolOs deleted the extendDefaults branch November 27, 2024 21:50
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Dec 2, 2024
##### [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))

##### 🩹 Fixes

-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))
-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))
-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))

##### ❤️  Thank You

-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)
-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)
-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Dec 2, 2024
##### [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))

##### 🩹 Fixes

-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))
-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))
-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))

##### ❤️  Thank You

-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)
-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)
-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 3, 2024
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.16.0 | 8.17.0 |
| npm        | @typescript-eslint/parser        | 8.16.0 | 8.17.0 |


## [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))

##### 🩹 Fixes

-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))
-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))
-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))

##### ❤️  Thank You

-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)
-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)
-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 3, 2024
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.16.0 | 8.17.0 |
| npm        | @typescript-eslint/parser        | 8.16.0 | 8.17.0 |


## [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))

##### 🩹 Fixes

-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))
-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))
-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))

##### ❤️  Thank You

-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)
-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)
-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants