refactor: move OAuth2 provider code to dedicated package #18746
Merged
+1,095
−981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2025
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
74ada5e to
94f8522
Compare
johnstcn
approved these changes
Jul 3, 2025
ThomasK33
force-pushed
the
thomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints
branch
from
665993d to
5d752e3
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
94f8522 to
c160ba6
Compare
ThomasK33
force-pushed
the
thomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints
branch
from
5d752e3 to
e8b598e
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
c160ba6 to
912fd87
Compare
ThomasK33
force-pushed
the
thomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints
branch
from
e8b598e to
d7cac75
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
912fd87 to
a2737b7
Compare
ThomasK33
force-pushed
the
thomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints
branch
from
d7cac75 to
cb75f3a
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
a2737b7 to
865dc56
Compare
ThomasK33
force-pushed
the
thomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints
branch
2 times, most recently
from
f62413e to
9965337
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
865dc56 to
1f89b53
Compare
ThomasK33
changed the base branch from
thomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints
to
graphite-base/18746
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
1f89b53 to
db0f2a0
Compare
ThomasK33
force-pushed
the
graphite-base/18746
branch
from
9965337 to
7fbb3ce
Compare
- Rename identityprovider package to oauth2provider for clarity - Extract OAuth2 business logic from coderd/oauth2.go into focused modules: - apps.go: OAuth2 app management (CRUD operations) - app_secrets.go: OAuth2 app secrets management - metadata.go: OAuth2 server and resource metadata endpoints - registration.go: RFC 7591/7592 dynamic client registration - Update route handlers to delegate to oauth2provider functions - Preserve all existing API endpoints and Swagger documentation - Fix compilation issues and update middleware references - All tests passing with zero regressions This refactoring improves code organization and maintainability while preserving complete API compatibility. Change-Id: Ieef7cf3683ec93667f09a0d4894190a1e1a0b16e Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
db0f2a0 to
a586976
Compare
Merge activity
|
ThomasK33
deleted the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor OAuth2 Provider Code into Dedicated Package
This PR refactors the OAuth2 provider functionality by moving it from the main
coderdpackage into a dedicatedoauth2providerpackage. The change improves code organization and maintainability without changing functionality.Key changes:
oauth2providerpackage to house all OAuth2 provider-related codecoderd/identityproviderto the new packagehttp.HandlerFuncinstead of being handlers directlyapp_secrets.go- Manages OAuth2 application secretsapps.go- Handles OAuth2 application CRUD operationsauthorize.go- Implements the authorization flowmetadata.go- Provides OAuth2 metadata endpointsregistration.go- Handles dynamic client registrationrevoke.go- Implements token revocationsecrets.go- Manages secret generation and validationtokens.go- Handles token issuance and validationThis refactoring improves code organization and makes the OAuth2 provider functionality more maintainable while preserving all existing behavior.