refactor: organize OAuth2 provider tests into dedicated packages #18747
+1,334
−413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2025
This was referenced Jul 3, 2025
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
15cf36d to
18ac26b
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
74ada5e to
94f8522
Compare
ThomasK33
changed the title
johnstcn
approved these changes
Jul 3, 2025
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
94f8522 to
c160ba6
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
18ac26b to
8d14c45
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
c160ba6 to
912fd87
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
8d14c45 to
a97c96a
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
912fd87 to
a2737b7
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
a97c96a to
c261955
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
a2737b7 to
865dc56
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
c261955 to
2822d49
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
from
865dc56 to
1f89b53
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
2822d49 to
b6bbf89
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
branch
2 times, most recently
from
db0f2a0 to
a586976
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
b6bbf89 to
572628e
Compare
ThomasK33
changed the base branch from
thomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package
to
graphite-base/18747
ThomasK33
force-pushed
the
graphite-base/18747
branch
from
a586976 to
c650133
Compare
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
572628e to
7af15df
Compare
- Create oauth2provider/metadata_test.go with OAuth2 metadata endpoint tests - Create oauth2provider/validation_test.go with comprehensive client validation tests - Create oauth2provider/provider_test.go with provider app and registration tests - Remove duplicated tests from coderd/oauth2_test.go, keep integration tests - Fix lint issues in oauth2providertest package naming - Improve test organization with unit tests separated from integration tests - Maintain 100% test coverage while enabling faster test execution Change-Id: I99aac9f53df95eed3135d895781831a4a2749f6a Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
from
7af15df to
860ba25
Compare
Merge activity
|
ThomasK33
deleted the
thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuth2 Provider Code Reorganization
This PR reorganizes the OAuth2 provider code to improve separation of concerns and maintainability. The changes include:
coderd/oauth2_test.gotooauth2provider/provider_test.gooauth2provider/validation_test.goOAuth2ProviderAppSecrettoAppSecretfor better naming consistencyoauth2_test.goto focus on core functionalityThe PR maintains all existing test coverage while organizing the code more logically, making it easier to understand and maintain the OAuth2 provider implementation. This reorganization will help with future enhancements to the OAuth2 provider functionality.